Separate title and description typeface#167
Merged
xiphirx merged 2 commits intoKeepSafe:masterfrom May 6, 2017
danimahardhika:patch
Merged
Separate title and description typeface#167xiphirx merged 2 commits intoKeepSafe:masterfrom danimahardhika:patch
xiphirx merged 2 commits intoKeepSafe:masterfrom
danimahardhika:patch
Conversation
- Added textTypeface(titleTypeface, descriptionTypeface)
xiphirx
requested changes
May 6, 2017
| import android.support.annotation.ColorRes; | ||
| import android.support.annotation.DimenRes; | ||
| import android.support.annotation.IdRes; | ||
| import android.support.annotation.NonNull; |
Collaborator
There was a problem hiding this comment.
This is not necessary. The project assumes non null wherever there isn't a nullable annotation
|
|
||
| /** Specify the typeface for title and description text **/ | ||
| public TapTarget textTypeface(@NonNull Typeface titleTypeface, @NonNull Typeface descriptionTypeface) { | ||
| this.titleTypeface = titleTypeface; |
Collaborator
There was a problem hiding this comment.
This is not a friendly API, it is forcing users to specify both, even though a large amount of cases don't need different typefaces between the title and description. This should be split up into titleTypeface and descriptionTypeface builder methods instead.
Additionally these methods need the null check that you removed from the original textTypeface
Contributor
Author
There was a problem hiding this comment.
It's needed when using typeface from assets folder. I'm going to change tit.
- titleTypeface(Typeface) - descriptionTypeface(Typeface)
xiphirx
approved these changes
May 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
textTypeface(titleTypeface, descriptionTypeface)