Return TapTargets in all factory methods#135
Merged
xiphirx merged 1 commit intoKeepSafe:masterfrom Feb 13, 2017
ChristianKatzmann:cb/tap_targets_ftw
Merged
Return TapTargets in all factory methods#135xiphirx merged 1 commit intoKeepSafe:masterfrom ChristianKatzmann:cb/tap_targets_ftw
xiphirx merged 1 commit intoKeepSafe:masterfrom
ChristianKatzmann:cb/tap_targets_ftw
Conversation
Collaborator
|
Great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need that we return the implementations / extension. The base
TapTargetwill be enough.On a side node: Even if we would return
ToolbarTapTargetoderViewTapTarget, we would loose this information on the first builder method call as they all returnTapTarget