UnsupportedOperationException on API 15

[marbat87]

• I have verified the issue exists on the latest version
• I am able to reproduce it

There is an issue with clipPath on API 15 because it is not supported with hardware acceleration enabled.

Version used:
1.9.1

Stack trace:
Exception java.lang.UnsupportedOperationException: android.view.GLES20Canvas.clipPath (GLES20Canvas.java:412) com.getkeepsafe.taptargetview.TapTargetView.onDraw () android.view.View.draw (View.java:11015) android.view.View.getHardwareLayer (View.java:10253) android.view.ViewGroup.drawChild (ViewGroup.java:2947) android.view.ViewGroup.dispatchDraw (ViewGroup.java:2573) android.view.View.draw (View.java:11018) android.widget.FrameLayout.draw (FrameLayout.java:450) com.android.internal.policy.impl.PhoneWindow$DecorView.draw (PhoneWindow.java:2137) android.view.View.getDisplayList (View.java:10454) android.view.HardwareRenderer$GlRenderer.draw (HardwareRenderer.java:851) android.view.ViewRootImpl.draw (ViewRootImpl.java:2034) android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:1748) android.view.ViewRootImpl.handleMessage (ViewRootImpl.java:2583) android.os.Handler.dispatchMessage (Handler.java:99) android.os.Looper.loop (Looper.java:137) android.app.ActivityThread.main (ActivityThread.java:4506) java.lang.reflect.Method.invokeNative (Method.java) java.lang.reflect.Method.invoke (Method.java:511) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:809) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:576) dalvik.system.NativeStart.main (NativeStart.java)

Android version:
4.0.3

[sebastianperdomo]

Same issue here...API 15 (4.0.4)

05-02 15:17:06.379 4899-4899/mobiliza32.fyb E/dalvikvm: Could not find class 'com.getkeepsafe.taptargetview.TapTargetView$12', referenced from method com.getkeepsafe.taptargetview.TapTargetView.applyTargetOptions
05-02 15:17:07.279 4899-4899/mobiliza32.fyb E/AndroidRuntime: FATAL EXCEPTION: main
java.lang.UnsupportedOperationException
at android.view.GLES20Canvas.clipPath(GLES20Canvas.java:429)
at com.getkeepsafe.taptargetview.TapTargetView.onDraw(TapTargetView.java:661)
at android.view.View.draw(View.java:11054)
at android.view.View.getHardwareLayer(View.java:10292)
at android.view.ViewGroup.drawChild(ViewGroup.java:2971)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2596)
at android.view.View.draw(View.java:11057)
at android.widget.FrameLayout.draw(FrameLayout.java:463)
at com.android.internal.policy.impl.PhoneWindow$DecorView.draw(PhoneWindow.java:2145)
at android.view.View.getDisplayList(View.java:10493)
at android.view.HardwareRenderer$GlRenderer.draw(HardwareRenderer.java:880)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:1911)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1635)
at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2455)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4424)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:817)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584)
at dalvik.system.NativeStart.main(Native Method)

[xiphirx]

Thanks for the reports, working on a fix.

[xiphirx]

@marbat87 please try out the snapshot build and verify that you can no longer reproduce please. Thanks!

[sebastianperdomo]

yes, now works, thanks

[marbat87]

@xiphirx I confirm that now it works.

Thanks

[niqueco]

Hi! Could you please consider releasing a new version? This is crashing my app in production and now I find this have been fixed for months.. Thanks, and thanks for this library!

[niqueco]

You should at least consider adding a warning to the README that this library crashes old Android versions, so nobody else gets burned as I did. (It would be simpler to release the fix instead, of course)

[xiphirx]

You can use a snapshot (from https://jitpack.io/#KeepSafe/TapTargetView/-SNAPSHOT) if you need a fix immediately. I'm a bit busy right now to go through and ensure the current code is releasable

[niqueco]

Thanks for the tip, I'll look into doing that.