Adds .Merge() method to combine model structs#12
Open
cicadian wants to merge 4 commits intoJujuAdams:masterfrom
Open
Adds .Merge() method to combine model structs#12cicadian wants to merge 4 commits intoJujuAdams:masterfrom
cicadian wants to merge 4 commits intoJujuAdams:masterfrom
Conversation
Owner
|
Thank you for your PR. As you note, this PR would only be compatible with a newer version of GameMaker than the one dotobj currently supports. I'll will consider how I want to proceed and, at a future time, I anticipate accepting this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: vertex_update_buffer_from_vertex(); is not available in LTS 2022. This functionality is commented out and must be manually turned back on and the project must be run in a more recent runtime to observe the feature being added.
#DotobjClassMesh LINE 120
Usage: Dotobj model class method .Merge(_model) where _model is another instantiated Dotobj model class
It calls subsequently added Merge methods for the groups and meshes of a model.
#DotobjClassModel LINE 65
#DotobjClassGroup LINE 58
#DotobjClassMesh LINE 93
Functionality:
Supplied in this project are 3 models (model_a, model_b, model_c) with different materials which have the appearance of the letters "A" "B" "C"
additional models, defined as model_ab, model_ba and model_abc are created and then merged with other models
Each are rendered in the scene individually