Skip reduce total tokens in every step & Fix total samples for sp resume#1652
Open
jayhenry wants to merge 10 commits intoInternLM:mainfrom
Open
Skip reduce total tokens in every step & Fix total samples for sp resume#1652jayhenry wants to merge 10 commits intoInternLM:mainfrom
jayhenry wants to merge 10 commits intoInternLM:mainfrom
Conversation
… data-parallel groups
HAOCHENYE
approved these changes
Apr 3, 2026
| return True | ||
|
|
||
| def _save_dataloader(self, dataloader_path: Path | str): | ||
| def _save_dataloader(self, dataloader_path: Path | str) -> int: |
Collaborator
There was a problem hiding this comment.
_save_dataloader should only save rather than return the total_consumed_steps
| approximate_total_consumed_tokens = ( | ||
| self._init_total_tokens + self._local_total_consumed_tokens * self.world_size | ||
| ) | ||
| approximate_total_consumed_tokens_per_rank = approximate_total_consumed_tokens / self.world_size |
Collaborator
There was a problem hiding this comment.
approximate_total_consumed_tokens_per_rank could be incorrect if world_size changed
| Args: | ||
| state_dict (dict): The state of the sampler. | ||
| """ | ||
| tc = int(state_dict.get("total_consumed_steps", 0)) |
Collaborator
There was a problem hiding this comment.
Avoid single charactor short abbr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.