Skip to content

fix bug with column names for coaches columns #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flosch1006 merged 1 commit into from
Mar 19, 2026
Merged

fix bug with column names for coaches columns #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions impectPy/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ def fetch_set_pieces(connection, url):
coaches_map = coaches.set_index("id")["name"].to_dict()

# convert coachId to integer if it is None
events["homeSquadCoachId"] = events["homeSquadCoachId"].astype("Int64")
events["awaySquadCoachId"] = events["awaySquadCoachId"].astype("Int64")
events["homeSquadCoachName"] = events.homeSquadCoachId.map(coaches_map)
events["awaySquadCoachName"] = events.awaySquadCoachId.map(coaches_map)
events["homeCoachId"] = events["homeSquadCoachId"].astype("Int64")
events["awayCoachId"] = events["awaySquadCoachId"].astype("Int64")
events["homeCoachName"] = events.homeSquadCoachId.map(coaches_map)
events["awayCoachName"] = events.awaySquadCoachId.map(coaches_map)

if include_kpis:
# unnest scorings and full join with kpi list to ensure all kpis are present
Expand Down