Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# impectPy 2.5.2

## Minor Changes
* fix bugs in the following functions that occured if the coaches endpoint returned coaches for the iteration but the match does not have any coaches:
* `getEvents()`
* `getPlayerMatchSums()`
* `getSquadMatchSums()`
* `getPlayerMatchScores()`
* `getSquadMatchScores()`

# impectPy 2.5.1

## Minor Changes
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

A package provided by: Impect GmbH

Version: v2.5.1
Version: v2.5.2

**Updated: October 17th 2025**
**Updated: October 20th 2025**

---

Expand Down Expand Up @@ -35,7 +35,7 @@ pip install impectPy
You can also install it from [GitHub](https://github.com/) with:

```cmd
pip install git+https://github.com/ImpectAPI/impectPy.git@v2.5.1
pip install git+https://github.com/ImpectAPI/impectPy.git@v2.5.2
```

## Usage
Expand Down
2 changes: 1 addition & 1 deletion impectPy/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# define version attribute
__version__ = "2.5.1"
__version__ = "2.5.2"

# import modules
from .access_token import getAccessToken
Expand Down
4 changes: 4 additions & 0 deletions impectPy/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ def getEventsFromHost(
)

if not coaches_blacklisted:

# convert coachId to integer if it is None
events["homeSquadCoachId"] = events["homeSquadCoachId"].astype("Int64")
events["awaySquadCoachId"] = events["awaySquadCoachId"].astype("Int64")
events = events.merge(
coaches[["id", "name"]].rename(columns={"id": "homeCoachId", "name": "homeCoachName"}),
left_on="homeSquadCoachId",
Expand Down
2 changes: 2 additions & 0 deletions impectPy/matchsums.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ def getPlayerMatchsumsFromHost(matches: list, connection: RateLimitedAPI, host:
)

if not coaches_blacklisted:
matchsums["coachId"] = matchsums["coachId"].astype("Int64")
matchsums = matchsums.merge(
coaches[["id", "name"]].rename(
columns={"id": "coachId", "name": "coachName"}
Expand Down Expand Up @@ -526,6 +527,7 @@ def getSquadMatchsumsFromHost(matches: list, connection: RateLimitedAPI, host: s
)

if not coaches_blacklisted:
matchsums["coachId"] = matchsums["coachId"].astype("Int64")
matchsums = matchsums.merge(
coaches[["id", "name"]].rename(
columns={"id": "coachId", "name": "coachName"}
Expand Down
1 change: 1 addition & 0 deletions impectPy/player_scores.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ def getPlayerMatchScoresFromHost(matches: list, connection: RateLimitedAPI, host
)

if not coaches_blacklisted:
player_scores["coachId"] = player_scores["coachId"].astype("Int64")
player_scores = player_scores.merge(
coaches[["id", "name"]].rename(
columns={"id": "coachId", "name": "coachName"}
Expand Down
1 change: 1 addition & 0 deletions impectPy/squad_scores.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ def getSquadMatchScoresFromHost(matches: list, connection: RateLimitedAPI, host:
)

if not coaches_blacklisted:
squad_scores["coachId"] = squad_scores["coachId"].astype("Int64")
squad_scores = squad_scores.merge(
coaches[["id", "name"]].rename(
columns={"id": "coachId", "name": "coachName"}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"pandas>=2.0.0",
"numpy>=1.24.2,<2.0"],
# *strongly* suggested for sharing
version="2.5.1",
version="2.5.2",
# The license can be anything you like
license="MIT",
description="A Python package to facilitate interaction with the Impect customer API",
Expand Down