Skip to content

Add max_issues_per_detector as parameter inside the scanner#1987

Merged
rabah-khalek merged 5 commits intomainfrom
max_issues_per_detector
Jul 22, 2024
Merged

Add max_issues_per_detector as parameter inside the scanner#1987
rabah-khalek merged 5 commits intomainfrom
max_issues_per_detector

Conversation

@bmalezieux
Copy link
Contributor

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@bmalezieux bmalezieux requested a review from rabah-khalek July 18, 2024 14:35
@sentry
Copy link

sentry bot commented Jul 18, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/scanner/scanner.py

Function Unhandled Issue
analyze RuntimeError: (sqlite3.OperationalError) database is locked main ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rabah-khalek
Copy link
Contributor

please make sure the precommit checks pass @bmalezieux (check pre-commit run --all-files)

@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Jul 22, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Jul 22, 2024
@sonarqubecloud
Copy link

@rabah-khalek rabah-khalek merged commit fce03e2 into main Jul 22, 2024
@rabah-khalek rabah-khalek deleted the max_issues_per_detector branch July 22, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants