Skip to content

Fix ArgumentCountError: pass IMailer and LoggerInterface to all Principal instantiation sites#1

Draft
Copilot wants to merge 5 commits intomasterfrom
copilot/add-calendar-delegation-functionality
Draft

Fix ArgumentCountError: pass IMailer and LoggerInterface to all Principal instantiation sites#1
Copilot wants to merge 5 commits intomasterfrom
copilot/add-calendar-delegation-functionality

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 12, 2026

  • Fix ArgumentCountError: add IMailer + LoggerInterface to files_versions Principal instantiation
  • Fix 404 on delegated calendar discovery: handle proxy principal URLs in Plugin::getCalendarHomeForPrincipal
  • Fix 404 crash on depth-1 PROPFIND of delegated calendar home caused by TrashbinHome having no proxy ACL:
    • Add getACL() to TrashbinHome granting {DAV:}all to owner and {DAV:}read to calendar-proxy-write / calendar-proxy-read group principals
    • Add TrashbinHomeTest covering the new ACL behaviour

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

… and delegation email notifications

Co-authored-by: GVodyanov <76647797+GVodyanov@users.noreply.github.com>
Copilot AI changed the title [WIP] Add server-side implementation for calendar delegation Add calendar delegation: proxy ACL on CalendarHome, proxy group ACL, and delegate email notifications Mar 12, 2026
…ions Principal instantiation

Co-authored-by: GVodyanov <76647797+GVodyanov@users.noreply.github.com>
Copilot AI changed the title Add calendar delegation: proxy ACL on CalendarHome, proxy group ACL, and delegate email notifications Fix ArgumentCountError: pass IMailer and LoggerInterface to all Principal instantiation sites Mar 12, 2026
…::getCalendarHomeForPrincipal

Co-authored-by: GVodyanov <76647797+GVodyanov@users.noreply.github.com>
Agent-Logs-Url: https://github.com/GVodyanov/nextcloud-server/sessions/e410e30e-7bf7-43cd-bb30-1f9d9cfedcf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants