Skip to content

Fix flaky exception debugger test #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpbempel merged 1 commit into from
May 29, 2024
Merged

Fix flaky exception debugger test #7084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...t-debugger/src/test/java/com/datadog/debugger/exception/DefaultExceptionDebuggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,13 @@ public void doubleHandleException() {
@Test
public void nestedException() {
RuntimeException exception = createNestException();
String fingerprint = Fingerprinter.fingerprint(exception, classNameFiltering);
AgentSpan span = mock(AgentSpan.class);
doAnswer(this::recordTags).when(span).setTag(anyString(), anyString());
exceptionDebugger.handleException(exception, span);
assertWithTimeout(
() -> exceptionDebugger.getExceptionProbeManager().isAlreadyInstrumented(fingerprint),
Duration.ofSeconds(30));
generateSnapshots(exception);
exception.printStackTrace();
exceptionDebugger.handleException(exception, span);
Expand Down Expand Up @@ -144,7 +148,9 @@ public void nestedException() {
@Test
public void doubleNestedException() {
RuntimeException nestedException = createNestException();
String nestedFingerprint = Fingerprinter.fingerprint(nestedException, classNameFiltering);
RuntimeException simpleException = new RuntimeException("test");
String simpleFingerprint = Fingerprinter.fingerprint(simpleException, classNameFiltering);
AgentSpan span = mock(AgentSpan.class);
doAnswer(this::recordTags).when(span).setTag(anyString(), anyString());
when(span.getTag(anyString()))
Expand All @@ -154,6 +160,12 @@ public void doubleNestedException() {
exceptionDebugger.handleException(nestedException, span);
// instrument first simple Exception
exceptionDebugger.handleException(simpleException, span);
assertWithTimeout(
() -> exceptionDebugger.getExceptionProbeManager().isAlreadyInstrumented(nestedFingerprint),
Duration.ofSeconds(30));
assertWithTimeout(
() -> exceptionDebugger.getExceptionProbeManager().isAlreadyInstrumented(simpleFingerprint),
Duration.ofSeconds(30));
generateSnapshots(nestedException);
generateSnapshots(simpleException);
exceptionDebugger.handleException(simpleException, span);
Expand Down