Skip to content

Fix reward of SimpleMultiObsEnv to always be float#1676

Merged
araffin merged 6 commits intoDLR-RM:masterfrom
NixGD:patch-1
Sep 16, 2023
Merged

Fix reward of SimpleMultiObsEnv to always be float#1676
araffin merged 6 commits intoDLR-RM:masterfrom
NixGD:patch-1

Conversation

@NixGD
Copy link
Copy Markdown
Contributor

@NixGD NixGD commented Sep 15, 2023

Previously the reward was sometimes returned as an int.

Description

Motivation and Context

Closes #1675

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Previously the reward was sometimes returned as an int.
@qgallouedec
Copy link
Copy Markdown
Collaborator

Thanks for reporting @NixGD, will be merged as soon as the CI has been passed.

Copy link
Copy Markdown
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks =)

@araffin araffin merged commit 1cd6ae4 into DLR-RM:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SimpleMultiObsEnv sometimes returns an integer reward (instead of float)

3 participants