-
-
Notifications
You must be signed in to change notification settings - Fork 618
NW6 | Hadika Malik | HTML-CSS | Module-Project | Week 1 + Week 2 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HadikaMalik
wants to merge
14
commits into
CodeYourFuture:master
Choose a base branch
from
HadikaMalik:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
90603d5
draft 1
HadikaMalik a829614
draft 1
HadikaMalik 4764489
draft 2
HadikaMalik 94623e8
draft2
HadikaMalik d22b047
final version
HadikaMalik 5fd3daf
level 2 feature homepage draft 1
HadikaMalik 8d52894
homepage addition
HadikaMalik 316c426
trial for feedback css styling
HadikaMalik 229b06f
feedback implemented added homepage feature
HadikaMalik 83e2062
speechmarks colour added
HadikaMalik 59f1491
semantic html
HadikaMalik daa5cd5
semantic htmls draft
HadikaMalik e726eb2
form completed, radio check button arrow left
HadikaMalik 4a87ccf
final version
HadikaMalik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,10 +10,113 @@ | |
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
| </head> | ||
| <body> | ||
| <header class="header"> | ||
| <a href="#"> | ||
| <img | ||
| src="img/karma-logo.svg" | ||
| alt="karma logo" | ||
| class="header_logo" | ||
| /> | ||
| </a> | ||
| <nav> | ||
| <ul class="navigation_list"> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link1" href="#">Meet Karma</a> | ||
| </li> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">How it Works</a> | ||
| </li> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">Store</a> | ||
| </li> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">Blog</a> | ||
| </li> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">Help</a> | ||
| </li> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">Login</a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
|
|
||
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
| <main class="content"> | ||
| <section class="hero"> | ||
| <h1>Introducing Karma</h1> | ||
| <p>Bring WiFi with you, everywhere you go.</p> | ||
| <button class="orange-button">Learn More</button> | ||
| </section> | ||
| <section class="points"> | ||
| <h2 class="second_heading">Everyone needs a little Karma.</h2> | ||
|
|
||
| <section class="container"> | ||
| <article class="articles"> | ||
| <img | ||
| class="images" | ||
| src="img/icon-devices.svg" | ||
| alt="devices image" | ||
| /> | ||
| <p class="article_title">Internet for all devices</p> | ||
| </article> | ||
|
|
||
| <article class="articles"> | ||
| <img | ||
| class="images" | ||
| src="img/icon-coffee.svg" | ||
| alt="devices image" | ||
| /> | ||
| <p class="article_title">Boost your productivity</p> | ||
| </article> | ||
|
|
||
| <article class="articles"> | ||
| <img | ||
| class="images" | ||
| src="img/icon-refill.svg" | ||
| alt="devices image" | ||
| /> | ||
| <p class="article_title">Pay as You Go</p> | ||
| </article> | ||
| </section> | ||
|
|
||
| </section> | ||
|
|
||
| <section class="feature"> | ||
| <img | ||
| class="homepage-feature" | ||
| src="level-2/homepage-feature.png" | ||
| alt="happy woman" | ||
| /> | ||
|
|
||
| <article class="feedback"> | ||
| <p class="speechmarks"><span>"</span>Wherever I am, I just don't worry about my connection anymore!<span>"</span></p> | ||
| <button class="orange-button">Get Karma today</button> | ||
| </article> | ||
| </section> | ||
|
|
||
| </main> | ||
| <hr> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the color for this element is a bit different |
||
| <footer class="footer"> | ||
| <section class="footer_content"> | ||
| <p class="Join">Join us on</p> | ||
| <img | ||
| class="footer_img" | ||
| src="img/twitter-icon.svg" | ||
| alt="twitter-icon" | ||
| /> | ||
| <img | ||
| class="footer_img" | ||
| src="img/facebook-icon.svg" | ||
| alt="facebook-icon" | ||
| /> | ||
| <img | ||
| class="footer_img" | ||
| src="img/instagram-icon.svg" | ||
| alt="instagram-icon" | ||
| /> | ||
| <p class="copyright">@Karma Mobility Inc.</p> | ||
| </section> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this class
orange-buttondoesnt exist in your css, you can remove unused classes. Also, this button seems to have a border width on it, can you remove it?