Add --base <run_id> to compare local run with another run#273
Open
GuillaumeLagrange wants to merge 3 commits intomainfrom
Open
Add --base <run_id> to compare local run with another run#273GuillaumeLagrange wants to merge 3 commits intomainfrom
GuillaumeLagrange wants to merge 3 commits intomainfrom
Conversation
f190462 to
8673a9c
Compare
7e5e798 to
753dc1f
Compare
Add --base cli argument and simplify polling code 1. If a base run id is provided, we now use the `compareRunsPaginated` resolver and display results from there 2. If a base run id is not provided or if the base run id is not correct (missing, executor mismatch...), we display the single mode results This overall simplifies the polling code and gets rid of the artificial "for_run" and "for_exec" distinctions.
0fffde9 to
2d85f8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.