Conversation
Review Summary by QodoAdd Ghostscript 10.07.0 version support and update release properties WalkthroughsDescription• Add Ghostscript 10.07.0 version support with configuration files • Update bundle release version to 2026.4.12 • Register new release in releases.properties mapping Diagramflowchart LR
A["Ghostscript 10.07.0"] --> B["Configuration Files"]
B --> C["bearsampp.conf"]
B --> D["update_cidfmap.bat"]
A --> E["Release Properties"]
E --> F["releases.properties"]
E --> G["build.properties"]
F --> H["GitHub Release URL"]
G --> I["Version 2026.4.12"]
File Changes1. bin/ghostscript10.07.0/update_cidfmap.bat
|
Code Review by Qodo
|
Comment on lines
+3
to
+4
| cd %~dp0 | ||
| bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps |
There was a problem hiding this comment.
1. Unquoted batch paths 🐞 Bug ≡ Correctness
update_cidfmap.bat uses cd %~dp0 (no quotes, no /d) and then runs a relative bin\gswin64c.exe; if the module lives in a path with spaces or on a different drive, cd can fail and the script may fail or run an unintended executable. This can prevent CIDF map generation and is risky because execution depends on the caller’s working directory.
Agent Prompt
### Issue description
`bin/ghostscript10.07.0/update_cidfmap.bat` uses `cd %~dp0` (no quotes, no `/d`) and calls a relative `bin\gswin64c.exe`. This breaks when the script directory contains spaces or is on a different drive than the current working directory, and can accidentally execute the wrong binary.
### Issue Context
This script is copied into the final packaged bundle and is intended to be executed by end users to regenerate `lib/cidfmap`.
### Fix Focus Areas
- bin/ghostscript10.07.0/update_cidfmap.bat[1-4]
### Suggested change
- Use `pushd "%~dp0"` (or `cd /d "%~dp0"`) to reliably change drive + directory.
- Quote the executable path (e.g., `"%~dp0bin\gswin64c.exe" ...`) and consider guarding with `if not exist` plus `exit /b 1`.
- Optionally `popd` at the end and propagate `%ERRORLEVEL%`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.