Skip to content

ITS3: alignment code#15161

Merged
shahor02 merged 3 commits intoAliceO2Group:devfrom
f3sch:its3/align
Mar 27, 2026
Merged

ITS3: alignment code#15161
shahor02 merged 3 commits intoAliceO2Group:devfrom
f3sch:its3/align

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Mar 15, 2026

This removes entirely the previous misalignment code (that's why the digitiser is touched), adds the possibility to study different mis-alignment modes and its effect on the residuals and implements a more or less finished prototype to interface with GBL&MillePede to find back the injected mis-alignment.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for ec29880 at 2026-03-15 21:15:

## sw/BUILD/O2-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Mar 17, 2026

needs something like #15162

@f3sch f3sch marked this pull request as draft March 20, 2026 06:22
f3sch added 2 commits March 20, 2026 07:30
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch marked this pull request as ready for review March 25, 2026 12:53
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for a3b972a at 2026-03-25 22:10:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/15161-slc9_x86-64/0/Detectors/Upgrades/ITS3/alignment/src/AlignmentHierarchy.cxx:19:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

Removed math.h and added cmath for better compatibility.
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 7c07166 at 2026-03-26 18:16:

## sw/BUILD/o2codechecker-latest/log
100% tests passed, 0 tests failed out of 1


## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Mar 27, 2026

@shahor02 can we please merge this, the failing tests should be unrelated.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, one insignifican comment and one question below (will have more later)

Comment on lines +164 to +167
skew << 0, -posLoc[2], posLoc[1], posLoc[2], 0, -posLoc[0], -posLoc[1], posLoc[0], 0;
jac.topLeftCorner<3, 3>() = rotL2T;
jac.topRightCorner<3, 3>() = -rotL2T * skew;
jac.bottomRightCorner<3, 3>() = rotL2T;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on the logic behind this?

@shahor02 shahor02 merged commit ea49c66 into AliceO2Group:dev Mar 27, 2026
11 of 13 checks passed
@f3sch f3sch deleted the its3/align branch March 27, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants