Skip to content

Fix key error on getting the "testing" key on older contexts#1863

Merged
JeanChristopheMorinPerso merged 2 commits intoAcademySoftwareFoundation:mainfrom
JeanChristopheMorinPerso:fix_key_error_testing
Oct 27, 2024
Merged

Fix key error on getting the "testing" key on older contexts#1863
JeanChristopheMorinPerso merged 2 commits intoAcademySoftwareFoundation:mainfrom
JeanChristopheMorinPerso:fix_key_error_testing

Conversation

@JeanChristopheMorinPerso
Copy link
Copy Markdown
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Oct 26, 2024

Fixes #1862.

Now with a test to make sure we never regress.

…ing" key on older contexts

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner October 26, 2024 16:45
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (09bf497) to head (75c3177).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1863   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files         126      126           
  Lines       17217    17217           
  Branches     3017     3017           
=======================================
  Hits        10207    10207           
  Misses       6325     6325           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Oct 26, 2024
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 9c0fe83 into AcademySoftwareFoundation:main Oct 27, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the fix_key_error_testing branch October 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bake resolves with rez<3.2.0 can't be loaded due to missing testing key

2 participants