Powershell alias return correct exit codes#1778
Merged
JeanChristopheMorinPerso merged 3 commits intoAcademySoftwareFoundation:mainfrom Sep 22, 2024
Merged
Conversation
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
… a process as they both seem to miss certain circumstances Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
a20d7de to
fcc4b38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 58.41% 58.40% -0.01%
==========================================
Files 126 126
Lines 17163 17165 +2
Branches 3506 3506
==========================================
+ Hits 10025 10026 +1
- Misses 6473 6474 +1
Partials 665 665 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Looks like Python isn't installed to all of our action VMs? Not sure what other command I could use that's shell agnostic outside of |
Member
|
@brycegbrazen these tests are complex, so reuse what's already there and don't call python directly. Look at the |
JeanChristopheMorinPerso
requested changes
Jun 22, 2024
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Bryce Gattis <69012021+brycegbrazen@users.noreply.github.com>
JeanChristopheMorinPerso
approved these changes
Sep 19, 2024
instinct-vfx
approved these changes
Sep 20, 2024
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
…areFoundation#1778) Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed (AcademySoftwareFoundation#1778) --------- Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com> Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed.
Closes #1776.