Let missing brotli raise

Author: ismasan

spec/compressed_socket_spec.rb

@@ -2,8 +2,7 @@
 
 require 'datastar'
 require 'datastar/compressor/gzip'
-require 'datastar/compressor/brotli' rescue nil
-require 'zlib'
+require 'datastar/compressor/brotli'
 
 RSpec.describe 'Compressor compressed sockets' do
   let(:raw_socket) { StringSocket.new }
@@ -80,12 +79,8 @@ def bytes
     end
   end
 
-  describe 'Datastar::Compressor::Brotli::CompressedSocket' do
-    before do
-      skip 'brotli gem not available' unless brotli_available?
-    end
-
-    subject(:socket) { Datastar::Compressor::Brotli::CompressedSocket.new(raw_socket) }
+  describe Datastar::Compressor::Brotli::CompressedSocket do
+    subject(:socket) { described_class.new(raw_socket) }
 
     it 'compresses data and decompresses to original' do
       socket << sse_data
@@ -119,12 +114,4 @@ def bytes
     end
   end
 
-  private
-
-  def brotli_available?
-    require 'brotli'
-    true
-  rescue LoadError
-    false
-  end
 end

spec/compression_config_spec.rb

@@ -87,12 +87,6 @@
     end
 
     it 'returns first compressor (preferred) when client supports both' do
-      begin
-        require 'brotli'
-      rescue LoadError
-        skip 'brotli gem not available'
-      end
-
       config = described_class.build([:br, :gzip])
       request = build_request('Accept-Encoding' => 'br, gzip')
       compressor = config.negotiate(request)
@@ -181,14 +175,6 @@
   end
 
   describe 'Compressor::Brotli' do
-    before do
-      begin
-        require 'brotli'
-      rescue LoadError
-        skip 'brotli gem not available'
-      end
-    end
-
     subject(:compressor) { Datastar::Compressor::Brotli.new({}) }
 
     it 'has :br encoding' do

spec/dispatcher_spec.rb

@@ -612,8 +612,6 @@ def self.render_in(view_context) = %(<div id="foo">\n<span>#{view_context}</span
 
   describe 'compression' do
     it 'sets Content-Encoding: br when compression enabled and client accepts br' do
-      begin; require 'brotli'; rescue LoadError; skip 'brotli gem not available'; end
-
       request = build_request('/events', headers: { 'HTTP_ACCEPT_ENCODING' => 'br, gzip' })
       dispatcher = Datastar.new(request:, response:, view_context:, compression: true)
 
@@ -659,8 +657,6 @@ def self.render_in(view_context) = %(<div id="foo">\n<span>#{view_context}</span
     end
 
     it 'streams brotli-compressed data that decompresses correctly' do
-      begin; require 'brotli'; rescue LoadError; skip 'brotli gem not available'; end
-
       request = build_request('/events', headers: { 'HTTP_ACCEPT_ENCODING' => 'br' })
       dispatcher = Datastar.new(request:, response:, view_context:, compression: true, heartbeat: false)