Consistently use mut marker for tests that write to the database (#290)

Even within a transaction, as some requests may stall until transactions
with write requests are committed/aborted.

Author: PGijsbers

tests/routers/openml/dataset_tag_test.py

@@ -28,6 +28,7 @@ async def test_dataset_tag_rejects_unauthorized(key: ApiKey, py_api: httpx.Async
     assert error["code"] == "103"
 
 
+@pytest.mark.mut
 @pytest.mark.parametrize(
     "key",
     [ApiKey.ADMIN, ApiKey.SOME_USER, ApiKey.OWNER_USER],
@@ -48,6 +49,7 @@ async def test_dataset_tag(
     assert tag in tags
 
 
+@pytest.mark.mut
 async def test_dataset_tag_returns_existing_tags(py_api: httpx.AsyncClient) -> None:
     dataset_id, tag = 1, "test"
     response = await py_api.post(
@@ -58,6 +60,7 @@ async def test_dataset_tag_returns_existing_tags(py_api: httpx.AsyncClient) -> N
     assert response.json() == {"data_tag": {"id": str(dataset_id), "tag": ["study_14", tag]}}
 
 
+@pytest.mark.mut
 async def test_dataset_tag_fails_if_tag_exists(py_api: httpx.AsyncClient) -> None:
     dataset_id, tag = 1, "study_14"  # Dataset 1 already is tagged with 'study_14'
     response = await py_api.post(

tests/routers/openml/datasets_test.py

@@ -316,6 +316,7 @@ async def test_dataset_status_unauthorized(
     assert response.status_code == HTTPStatus.FORBIDDEN
 
 
+@pytest.mark.mut
 async def test_dataset_no_500_with_multiple_processing_entries(
     py_api: httpx.AsyncClient,
     expdb_test: AsyncConnection,

tests/routers/openml/migration/datasets_migration_test.py

@@ -156,6 +156,7 @@ async def test_private_dataset_owner_access(
     assert new_response.json()["id"] == private_dataset
 
 
+@pytest.mark.mut
 @pytest.mark.parametrize(
     "dataset_id",
     [*range(1, 10), 101, 131],

tests/routers/openml/migration/flows_migration_test.py

@@ -14,7 +14,6 @@
 from tests.conftest import Flow
 
 
-@pytest.mark.mut
 async def test_flow_exists_not(
     py_api: httpx.AsyncClient,
     php_api: httpx.AsyncClient,

tests/routers/openml/migration/setups_migration_test.py

@@ -47,6 +47,7 @@ async def _temporary_tags(
     return _temporary_tags
 
 
+@pytest.mark.mut
 @pytest.mark.parametrize(
     "api_key",
     [ApiKey.ADMIN, ApiKey.SOME_USER, ApiKey.OWNER_USER],
@@ -165,6 +166,7 @@ async def test_setup_untag_response_is_identical_tag_doesnt_exist(
     )
 
 
+@pytest.mark.mut
 @pytest.mark.parametrize(
     "api_key",
     [ApiKey.ADMIN, ApiKey.SOME_USER],
@@ -247,6 +249,7 @@ async def test_setup_tag_response_is_identical_setup_doesnt_exist(
     )
 
 
+@pytest.mark.mut
 async def test_setup_tag_response_is_identical_tag_already_exists(
     py_api: httpx.AsyncClient,
     php_api: httpx.AsyncClient,

tests/routers/openml/qualities_test.py

@@ -42,6 +42,7 @@ async def test_list_qualities_identical(
     # To keep the test idempotent, we cannot test if reaction to database changes is identical
 
 
+@pytest.mark.mut
 async def test_list_qualities(py_api: httpx.AsyncClient, expdb_test: AsyncConnection) -> None:
     response = await py_api.get("/datasets/qualities/list")
     assert response.status_code == HTTPStatus.OK

tests/routers/openml/study_test.py

@@ -2,6 +2,7 @@
 from http import HTTPStatus
 
 import httpx
+import pytest
 from sqlalchemy import text
 from sqlalchemy.ext.asyncio import AsyncConnection
 
@@ -458,6 +459,7 @@ async def test_get_task_study_by_alias(py_api: httpx.AsyncClient) -> None:
     assert response.json() == expected
 
 
+@pytest.mark.mut
 async def test_create_task_study(py_api: httpx.AsyncClient) -> None:
     response = await py_api.post(
         f"/studies?api_key={ApiKey.SOME_USER}",
@@ -516,6 +518,7 @@ async def _attach_tasks_to_study(
     )
 
 
+@pytest.mark.mut
 async def test_attach_task_to_study(py_api: httpx.AsyncClient, expdb_test: AsyncConnection) -> None:
     response = await _attach_tasks_to_study(
         study_id=1,
@@ -528,6 +531,7 @@ async def test_attach_task_to_study(py_api: httpx.AsyncClient, expdb_test: Async
     assert response.json() == {"study_id": 1, "main_entity_type": StudyType.TASK}
 
 
+@pytest.mark.mut
 async def test_attach_task_to_study_needs_owner(
     py_api: httpx.AsyncClient, expdb_test: AsyncConnection
 ) -> None:
@@ -542,6 +546,7 @@ async def test_attach_task_to_study_needs_owner(
     assert response.status_code == HTTPStatus.FORBIDDEN, response.content
 
 
+@pytest.mark.mut
 async def test_attach_task_to_study_already_linked_raises(
     py_api: httpx.AsyncClient,
     expdb_test: AsyncConnection,
@@ -561,6 +566,7 @@ async def test_attach_task_to_study_already_linked_raises(
     assert error["detail"] == "Task 1 is already attached to study 1."
 
 
+@pytest.mark.mut
 async def test_attach_task_to_study_but_task_not_exist_raises(
     py_api: httpx.AsyncClient,
     expdb_test: AsyncConnection,