Skip to content

Commit cdea2d0

Browse files
susnuxHephi2
authored andcommitted
fix(core): Do not invert app menu text color
* Also fixes other cypress test * Build assets Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 0d961dc commit cdea2d0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

core/src/components/AppMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ $header-icon-size: 20px;
147147
position: relative;
148148
display: flex;
149149
opacity: .7;
150-
filter: var(--background-image-invert-if-bright);
151150
152151
&.app-menu-entry__active {
153152
opacity: 1;
@@ -188,6 +187,7 @@ $header-icon-size: 20px;
188187
height: $header-icon-size;
189188
padding: calc((100% - $header-icon-size) / 2);
190189
box-sizing: content-box;
190+
filter: var(--background-image-invert-if-bright);
191191
}
192192
193193
.app-menu-entry--label {

cypress/e2e/theming/admin-settings.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ describe.only('Remove the default background with a bright color', function() {
167167

168168
it('See the header being inverted', function() {
169169
cy.waitUntil(() => cy.window().then((win) => {
170-
const firstEntry = win.document.querySelector('.app-menu-main li')
170+
const firstEntry = win.document.querySelector('.app-menu-main li img')
171171
if (!firstEntry) {
172172
return false
173173
}

cypress/e2e/theming/user-background.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ describe('User select a bright custom color and remove background', function() {
162162

163163
it('See the header being inverted', function() {
164164
cy.waitUntil(() => cy.window().then((win) => {
165-
const firstEntry = win.document.querySelector('.app-menu-main li')
165+
const firstEntry = win.document.querySelector('.app-menu-main li img')
166166
if (!firstEntry) {
167167
return false
168168
}

0 commit comments

Comments
 (0)