Skip to content

Commit a6adc6a

Browse files
committed
fix(integration-s3): Adjust integration test for changed test layout
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 3d7ed2e commit a6adc6a

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

.github/workflows/s3-primary-integration.yml renamed to .github/workflows/integration-s3-primary.yml

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
paths:
55
- '.github/workflows/**'
66
- '3rdparty/**'
7+
- 'build/integration/**'
78
- '**/*.php'
89
- '**/lib/**'
910
- '**/tests/**'
@@ -13,12 +14,12 @@ on:
1314
- 'composer.lock'
1415

1516
concurrency:
16-
group: s3-external-integration-${{ github.head_ref || github.run_id }}
17+
group: integration-s3-primary-${{ github.head_ref || github.run_id }}
1718
cancel-in-progress: true
1819

1920
jobs:
20-
s3-primary-integration-tests-minio:
21-
runs-on: ubuntu-20.04
21+
integration-s3-primary:
22+
runs-on: ubuntu-latest
2223

2324
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
2425

@@ -33,14 +34,16 @@ jobs:
3334

3435
services:
3536
redis:
36-
image: redis
37+
image: ghcr.io/nextcloud/continuous-integration-redis:latest
38+
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
3739
ports:
38-
- "6379:6379"
40+
- 6379:6379/tcp
3941
minio:
42+
image: bitnami/minio
4043
env:
41-
MINIO_ACCESS_KEY: minio
42-
MINIO_SECRET_KEY: minio123
43-
image: bitnami/minio:2021.12.29
44+
MINIO_ROOT_USER: nextcloud
45+
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
46+
MINIO_DEFAULT_BUCKETS: nextcloud
4447
ports:
4548
- "9000:9000"
4649

@@ -51,10 +54,13 @@ jobs:
5154
submodules: true
5255

5356
- name: Set up php ${{ matrix.php-versions }}
54-
uses: shivammathur/setup-php@c5fc0d8281aba02c7fda07d3a70cc5371548067d #v2.25.2
57+
uses: shivammathur/setup-php@4bd44f22a98a19e0950cbad5f31095157cc9621b # v2
5558
with:
5659
php-version: ${{ matrix.php-versions }}
57-
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd, redis
60+
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
61+
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
62+
coverage: 'none'
63+
ini-file: development
5864
env:
5965
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6066

@@ -66,15 +72,15 @@ jobs:
6672
- name: Set up Nextcloud
6773
run: |
6874
mkdir data
69-
echo '<?php $CONFIG=["${{ matrix.key }}" => ["class" => "OC\Files\ObjectStore\S3", "arguments" => ["bucket" => "nextcloud", "autocreate" => true, "key" => "minio", "secret" => "minio123", "hostname" => "localhost", "port" => 9000, "use_ssl" => false, "use_path_style" => true, "uploadPartSize" => 52428800]]];' > config/config.php
75+
echo '<?php $CONFIG=["${{ matrix.key }}" => ["class" => "OC\Files\ObjectStore\S3", "arguments" => ["bucket" => "nextcloud", "autocreate" => true, "key" => "nextcloud", "secret" => "bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=", "hostname" => "localhost", "port" => 9000, "use_ssl" => false, "use_path_style" => true, "uploadPartSize" => 52428800]]];' > config/config.php
7076
echo '<?php $CONFIG=["redis" => ["host" => "localhost", "port" => 6379], "memcache.local" => "\OC\Memcache\Redis", "memcache.distributed" => "\OC\Memcache\Redis"];' > config/redis.config.php
7177
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
7278
php -f index.php
7379
7480
- name: Integration
7581
run: |
7682
cd build/integration
77-
bash run.sh --tags "~@failure-s3" features/webdav-related.feature
83+
bash run.sh --tags "~@failure-s3" build/integration/dav_features/webdav-related.feature
7884
7985
- name: S3 logs
8086
if: always()
@@ -86,10 +92,10 @@ jobs:
8692
8793
s3-primary-integration-summary:
8894
runs-on: ubuntu-latest
89-
needs: [s3-primary-integration-tests-minio]
95+
needs: [integration-s3-primary]
9096

9197
if: always()
9298

9399
steps:
94100
- name: Summary status
95-
run: if ${{ needs.s3-primary-integration-tests-minio.result != 'success' }}; then exit 1; fi
101+
run: if ${{ needs.integration-s3-primary.result != 'success' }}; then exit 1; fi

0 commit comments

Comments
 (0)