Skip to content

Commit a367ccc

Browse files
skjnldsvbackportbot[bot]
authored andcommitted
fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> [skip ci]
1 parent b53cc98 commit a367ccc

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

apps/files/src/components/FileEntry.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
<FileEntryPreview ref="preview"
4848
:source="source"
4949
:dragover="dragover"
50+
@auxclick.native="execDefaultAction"
5051
@click.native="execDefaultAction" />
5152

5253
<FileEntryName ref="name"
@@ -55,7 +56,8 @@
5556
:files-list-width="filesListWidth"
5657
:nodes="nodes"
5758
:source="source"
58-
@click="execDefaultAction" />
59+
@auxclick.native="execDefaultAction"
60+
@click.native="execDefaultAction" />
5961
</td>
6062

6163
<!-- Actions -->

apps/files/src/components/FileEntry/FileEntryName.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@
4343
:aria-hidden="isRenaming"
4444
class="files-list__row-name-link"
4545
data-cy-files-list-row-name-link
46-
v-bind="linkTo.params"
47-
@click="$emit('click', $event)">
46+
v-bind="linkTo.params">
4847
<!-- File name -->
4948
<span class="files-list__row-name-text">
5049
<!-- Keep the displayName stuck to the extension to avoid whitespace rendering issues-->

apps/files/src/components/FileEntryGrid.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
:dragover="dragover"
5050
:grid-mode="true"
5151
:source="source"
52+
@auxclick.native="execDefaultAction"
5253
@click.native="execDefaultAction" />
5354

5455
<FileEntryName ref="name"
@@ -58,7 +59,8 @@
5859
:grid-mode="true"
5960
:nodes="nodes"
6061
:source="source"
61-
@click="execDefaultAction" />
62+
@auxclick.native="execDefaultAction"
63+
@click.native="execDefaultAction" />
6264
</td>
6365

6466
<!-- Actions -->

apps/files/src/components/FileEntryMixin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ export default defineComponent({
224224
},
225225

226226
execDefaultAction(event) {
227-
if (event.ctrlKey || event.metaKey) {
227+
// if ctrl+click or middle mouse button, open in new tab
228+
if (event.ctrlKey || event.metaKey || event.button === 1) {
228229
event.preventDefault()
229230
window.open(generateUrl('/f/{fileId}', { fileId: this.fileid }))
230231
return false

0 commit comments

Comments
 (0)