fix: Do not throw if appstore is unavailable during upgrade

juliusknorr · juliusknorr · commit 9f532b031da6 · 2024-08-16T18:21:42.000+02:00
Signed-off-by: Julius Härtl &lt;jus@bitgrid.net&gt;
diff --git a/lib/private/App/AppStore/Fetcher/Fetcher.php b/lib/private/App/AppStore/Fetcher/Fetcher.php
@@ -86,7 +86,8 @@ protected function fetch($ETag, $content) {
 			$response = $client->get($this->getEndpoint(), $options);
 		} catch (ConnectException $e) {
 			$this->config->setAppValue('settings', 'appstore-fetcher-lastFailure', (string)time());
-			throw $e;
+			$this->logger->error('Failed to connect to the app store', ['exception' => $e]);
+			return [];
 		}
 
 		$responseJson = [];

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ protected function fetch($ETag, $content) {`
`86`	`86`	`$response = $client->get($this->getEndpoint(), $options);`
`87`	`87`	`} catch (ConnectException $e) {`
`88`	`88`	`$this->config->setAppValue('settings', 'appstore-fetcher-lastFailure', (string)time());`
`89`		`- throw $e;`
	`89`	`+ $this->logger->error('Failed to connect to the app store', ['exception' => $e]);`
	`90`	`+ return [];`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`$responseJson = [];`