Skip to content

Commit 81ee1ce

Browse files
KocAndyScherzinger
authored andcommitted
fix(files): Disable tags editing for shared files/folders with view only permission
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
1 parent dda6dd0 commit 81ee1ce

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

apps/files/src/services/FileInfo.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export default async function(url) {
2424
// TODO remove when no more legacy backbone is used
2525
fileInfo.get = (key) => fileInfo[key]
2626
fileInfo.isDirectory = () => fileInfo.mimetype === 'httpd/unix-directory'
27+
fileInfo.canEdit = () => Boolean(fileInfo.permissions & OC.PERMISSION_UPDATE)
2728

2829
return fileInfo
2930
}

apps/files/src/views/Sidebar.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<div class="sidebar__description">
3131
<SystemTags v-if="isSystemTagsEnabled && showTagsDefault"
3232
v-show="showTags"
33+
:disabled="!fileInfo?.canEdit()"
3334
:file-id="fileInfo.id"
3435
@has-tags="value => showTags = value" />
3536
<LegacyView v-for="view in views"

apps/systemtags/src/components/SystemTags.vue

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
:options="sortedTags"
1616
:value="selectedTags"
1717
:create-option="createOption"
18+
:disabled="disabled"
1819
:taggable="true"
1920
:passthru="true"
2021
:fetch-tags="false"
@@ -65,6 +66,10 @@ export default Vue.extend({
6566
type: Number,
6667
required: true,
6768
},
69+
disabled: {
70+
type: Boolean,
71+
default: false,
72+
},
6873
},
6974
7075
data() {

0 commit comments

Comments
 (0)