Merge pull request #23093 from nextcloud/backport/23083/stable19

rullzer · web-flow · commit 75bc0bc10555 · 2020-09-29T16:39:00.000+02:00
[stable19] Generate exception to log on php errors
diff --git a/lib/private/Log/ErrorHandler.php b/lib/private/Log/ErrorHandler.php
@@ -88,12 +88,14 @@ public static function onError($number, $message, $file, $line) {
 			return;
 		}
 		$msg = $message . ' at ' . $file . '#' . $line;
-		self::$logger->error(self::removePassword($msg), ['app' => 'PHP']);
+		$e = new \Error(self::removePassword($msg));
+		self::$logger->logException($e, ['app' => 'PHP']);
 	}
 
 	//Recoverable handler which catch all errors, warnings and notices
 	public static function onAll($number, $message, $file, $line) {
 		$msg = $message . ' at ' . $file . '#' . $line;
-		self::$logger->debug(self::removePassword($msg), ['app' => 'PHP']);
+		$e = new \Error(self::removePassword($msg));
+		self::$logger->logException($e, ['app' => 'PHP', 'level' => 0]);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -88,12 +88,14 @@ public static function onError($number, $message, $file, $line) {`
`88`	`88`	`return;`
`89`	`89`	`}`
`90`	`90`	`$msg = $message . ' at ' . $file . '#' . $line;`
`91`		`- self::$logger->error(self::removePassword($msg), ['app' => 'PHP']);`
	`91`	`+ $e = new \Error(self::removePassword($msg));`
	`92`	`+ self::$logger->logException($e, ['app' => 'PHP']);`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`//Recoverable handler which catch all errors, warnings and notices`
`95`	`96`	`public static function onAll($number, $message, $file, $line) {`
`96`	`97`	`$msg = $message . ' at ' . $file . '#' . $line;`
`97`		`- self::$logger->debug(self::removePassword($msg), ['app' => 'PHP']);`
	`98`	`+ $e = new \Error(self::removePassword($msg));`
	`99`	`+ self::$logger->logException($e, ['app' => 'PHP', 'level' => 0]);`
`98`	`100`	`}`
`99`	`101`	`}`