Skip to content

Commit 74f667d

Browse files
ChristophWurstbackportbot[bot]
authored andcommitted
Do not print verbose info about app updates if there are none
This is cosmetical but if you have a large number of apps installed then you'll see a wall of text during the server and app upgrade when it tries to update each app via the app store. In may cases nothing will be updated. For those boring cases we can hide the verbose info, but show when occ is run with -v. Any actual update will still print a few lines. Those are the important ones for the admin. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 parent 1256331 commit 74f667d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

core/Command/Upgrade.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,6 @@ function ($success) use ($output, $self) {
212212
$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function ($app) use ($output) {
213213
$output->writeln('<comment>Disabled incompatible app: ' . $app . '</comment>');
214214
});
215-
$updater->listen('\OC\Updater', 'checkAppStoreAppBefore', function ($app) use ($output) {
216-
$output->writeln('<info>Checking for update of app ' . $app . ' in appstore</info>');
217-
});
218215
$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function ($app) use ($output) {
219216
$output->writeln('<info>Update app ' . $app . ' from appstore</info>');
220217
});

lib/private/Updater.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,13 +558,13 @@ private function logAllEvents() {
558558
$log->info('\OC\Updater::incompatibleAppDisabled: Disabled incompatible app: ' . $app, ['app' => 'updater']);
559559
});
560560
$this->listen('\OC\Updater', 'checkAppStoreAppBefore', function ($app) use ($log) {
561-
$log->info('\OC\Updater::checkAppStoreAppBefore: Checking for update of app "' . $app . '" in appstore', ['app' => 'updater']);
561+
$log->debug('\OC\Updater::checkAppStoreAppBefore: Checking for update of app "' . $app . '" in appstore', ['app' => 'updater']);
562562
});
563563
$this->listen('\OC\Updater', 'upgradeAppStoreApp', function ($app) use ($log) {
564564
$log->info('\OC\Updater::upgradeAppStoreApp: Update app "' . $app . '" from appstore', ['app' => 'updater']);
565565
});
566566
$this->listen('\OC\Updater', 'checkAppStoreApp', function ($app) use ($log) {
567-
$log->info('\OC\Updater::checkAppStoreApp: Checked for update of app "' . $app . '" in appstore', ['app' => 'updater']);
567+
$log->debug('\OC\Updater::checkAppStoreApp: Checked for update of app "' . $app . '" in appstore', ['app' => 'updater']);
568568
});
569569
$this->listen('\OC\Updater', 'appUpgradeCheckBefore', function () use ($log) {
570570
$log->info('\OC\Updater::appUpgradeCheckBefore: Checking updates of apps', ['app' => 'updater']);

0 commit comments

Comments
 (0)