Merge pull request #30698 from nextcloud/backport/30655/stable23

[stable23] Improve layout for the public download page

Author: MichaIng

apps/files_sharing/lib/Controller/ShareController.php

@@ -385,7 +385,7 @@ public function showShare($path = ''): TemplateResponse {
 		$shareTmpl['protected'] = $share->getPassword() !== null ? 'true' : 'false';
 		$shareTmpl['dir'] = '';
 		$shareTmpl['nonHumanFileSize'] = $shareNode->getSize();
-		$shareTmpl['fileSize'] = \OCP\Util::humanFileSize($shareNode->getSize());
+		$shareTmpl['fileSize'] = str_replace(' ', ' ', \OCP\Util::humanFileSize($shareNode->getSize()));
 		$shareTmpl['hideDownload'] = $share->getHideDownload();
 
 		$hideFileList = false;

apps/files_sharing/templates/public.php

@@ -75,7 +75,7 @@
 						<?php if (isset($_['mimetype']) && strpos($_['mimetype'], 'image') === 0) { ?>
 							<div class="directDownload">
 								<div>
-									<?php p($_['filename'])?> (<?php p($_['fileSize']) ?>)
+									<?php p($_['filename'])?> (<?php echo($_['fileSize']) ?>)
 								</div>
 								<a href="<?php p($_['downloadURL']); ?>" id="downloadFile" class="button">
 									<span class="icon icon-download"></span>
@@ -87,7 +87,7 @@
 				<?php if ($_['previewURL'] === $_['downloadURL'] && !$_['hideDownload']): ?>
 					<div class="directDownload">
 						<div>
-							<?php p($_['filename'])?> (<?php p($_['fileSize']) ?>)
+							<?php p($_['filename'])?> (<?php echo($_['fileSize']) ?>)
 						</div>
 						<a href="<?php p($_['downloadURL']); ?>" id="downloadFile" class="button">
 							<span class="icon icon-download"></span>

apps/files_sharing/tests/Controller/ShareControllerTest.php

@@ -329,7 +329,7 @@ public function testShowShare() {
 			'protected' => 'true',
 			'dir' => '',
 			'downloadURL' => 'downloadURL',
-			'fileSize' => '33 B',
+			'fileSize' => '33 B',
 			'nonHumanFileSize' => 33,
 			'maxSizeAnimateGif' => 10,
 			'previewSupported' => true,
@@ -480,7 +480,7 @@ public function testShowShareWithPrivateName() {
 			'protected' => 'true',
 			'dir' => '',
 			'downloadURL' => 'downloadURL',
-			'fileSize' => '33 B',
+			'fileSize' => '33 B',
 			'nonHumanFileSize' => 33,
 			'maxSizeAnimateGif' => 10,
 			'previewSupported' => true,
@@ -631,7 +631,7 @@ public function testShowShareHideDownload() {
 			'protected' => 'true',
 			'dir' => '',
 			'downloadURL' => 'downloadURL',
-			'fileSize' => '33 B',
+			'fileSize' => '33 B',
 			'nonHumanFileSize' => 33,
 			'maxSizeAnimateGif' => 10,
 			'previewSupported' => true,
@@ -756,7 +756,7 @@ public function testShareFileDrop() {
 			'protected' => 'false',
 			'dir' => null,
 			'downloadURL' => '',
-			'fileSize' => '1 KB',
+			'fileSize' => '1 KB',
 			'nonHumanFileSize' => 1337,
 			'maxSizeAnimateGif' => null,
 			'previewSupported' => null,

core/css/public.scss

@@ -1,8 +1,25 @@
-$footer-height: 65px;
-
 #body-public {
-	.header-right {
+	min-height: 100vh;
+	display: flex;
+	flex-direction: column;
+
+	#content {
+		flex-grow: 2;
+		min-height: initial;
 
+		/** Center the shared content inside the page */
+		&.app-files_sharing {
+			justify-content: center;
+			align-items: center;
+			#app-content {
+				min-height: inherit;
+				padding-left: 1rem;
+				padding-right: 1rem;
+			}
+		}
+	}
+
+	.header-right {
 		#header-primary-action a {
 			color: var(--color-primary-text);
 		}
@@ -35,12 +52,6 @@ $footer-height: 65px;
 		}
 	}
 
-	#content {
-		// 100% - footer
-		min-height: calc(100% - #{$footer-height});
-
-	}
-
 	/** don't apply content header padding on the base layout */
 	&.layout-base #content {
 		padding-top: 0;
@@ -72,8 +83,8 @@ $footer-height: 65px;
 		display: flex;
 		align-items: center;
 		justify-content: center;
-		height: $footer-height;
 		flex-direction: column;
+		padding: 0.5rem;
 		p {
 			text-align: center;
 			color: var(--color-text-lighter);