Skip to content

Commit 48bf654

Browse files
committed
Add fallback when a there is no preview for a version
Signed-off-by: Louis Chemineau <louis@chmn.me>
1 parent d1d944c commit 48bf654

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

apps/files_versions/src/components/Version.vue

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,15 @@
2323
:force-display-actions="true"
2424
data-files-versions-version>
2525
<template #icon>
26-
<img lazy="true"
26+
<img v-if="!previewError"
2727
:src="previewURL"
2828
alt=""
29-
height="256"
30-
width="256"
29+
class="version__image"
30+
@error="previewError = true">
31+
<div v-else
3132
class="version__image">
33+
<ImageOffOutline :size="20" />
34+
</div>
3235
</template>
3336
<template #subtitle>
3437
<div class="version__info">
@@ -112,6 +115,7 @@ import Download from 'vue-material-design-icons/Download.vue'
112115
import Pencil from 'vue-material-design-icons/Pencil.vue'
113116
import Check from 'vue-material-design-icons/Check.vue'
114117
import Delete from 'vue-material-design-icons/Delete.vue'
118+
import ImageOffOutline from 'vue-material-design-icons/ImageOffOutline.vue'
115119
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
116120
import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink.js'
117121
import NcListItem from '@nextcloud/vue/dist/Components/NcListItem.js'
@@ -139,6 +143,7 @@ export default {
139143
Pencil,
140144
Check,
141145
Delete,
146+
ImageOffOutline,
142147
},
143148
directives: {
144149
tooltip: Tooltip,
@@ -183,6 +188,7 @@ export default {
183188
showVersionLabelForm: false,
184189
formVersionLabelValue: this.version.label,
185190
capabilities: loadState('core', 'capabilities', { files: { version_labeling: false, version_deletion: false } }),
191+
previewError: false,
186192
}
187193
},
188194
computed: {
@@ -283,6 +289,11 @@ export default {
283289
height: 3rem;
284290
border: 1px solid var(--color-border);
285291
border-radius: var(--border-radius-large);
292+
293+
// Useful to display no preview icon.
294+
display: flex;
295+
justify-content: center;
296+
color: var(--color-main-text);
286297
}
287298
}
288299

dist/files_versions-files_versions.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_versions-files_versions.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)