clean up return and param values

Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>

Author: summersab

apps/dav/lib/CalDAV/CalDavBackend.php

@@ -2602,7 +2602,7 @@ public function deleteSubscription($subscriptionId) {
 	 *
 	 * @param string $principalUri
 	 * @param string $objectUri
-	 * @return array
+	 * @return array|null
 	 */
 	public function getSchedulingObject($principalUri, $objectUri) {
 		$query = $this->db->getQueryBuilder();

apps/dav/lib/CalDAV/ResourceBooking/AbstractPrincipalBackend.php

@@ -157,7 +157,7 @@ public function getPrincipalsByPrefix($prefixPath): array {
 	 *
 	 * @param string $prefixPath
 	 *
-	 * @return array
+	 * @return array|null
 	 */
 	public function getPrincipalByPath($path) {
 		if (strpos($path, $this->principalPrefix) !== 0) {

apps/dav/lib/CardDAV/CardDavBackend.php

@@ -543,7 +543,7 @@ public function getCards($addressbookId) {
 	 *
 	 * @param mixed $addressBookId
 	 * @param string $cardUri
-	 * @return array
+	 * @return array|false
 	 */
 	public function getCard($addressBookId, $cardUri) {
 		$query = $this->db->getQueryBuilder();

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

@@ -183,7 +183,7 @@ public function getSupportedReportSet($uri) {
 	public function onReport($reportName, $report, $uri) {
 		$reportTargetNode = $this->server->tree->getNodeForPath($uri);
 		if (!$reportTargetNode instanceof Directory || $reportName !== self::REPORT_NAME) {
-			return;
+			return false;
 		}
 
 		$ns = '{' . $this::NS_OWNCLOUD . '}';

apps/dav/lib/Connector/Sabre/Principal.php

@@ -159,7 +159,7 @@ public function getPrincipalsByPrefix($prefixPath) {
 	 * getPrincipalsByPrefix.
 	 *
 	 * @param string $path
-	 * @return array
+	 * @return array|null
 	 */
 	public function getPrincipalByPath($path) {
 		[$prefix, $name] = \Sabre\Uri\split($path);

apps/dav/lib/Connector/Sabre/TagsPlugin.php

@@ -158,7 +158,7 @@ private function getTagsAndFav($fileId) {
 	 * Returns tags for the given file id
 	 *
 	 * @param integer $fileId file id
-	 * @return array list of tags for that file
+	 * @return array|null list of tags for that file
 	 */
 	private function getTags($fileId) {
 		if (isset($this->cachedTags[$fileId])) {

apps/dav/lib/DAV/GroupPrincipalBackend.php

@@ -101,7 +101,7 @@ public function getPrincipalsByPrefix($prefixPath) {
 	 * getPrincipalsByPrefix.
 	 *
 	 * @param string $path
-	 * @return array
+	 * @return array|null
 	 */
 	public function getPrincipalByPath($path) {
 		$elements = explode('/', $path,  3);

apps/dav/lib/DAV/SystemPrincipalBackend.php

@@ -65,7 +65,7 @@ public function getPrincipalsByPrefix($prefixPath) {
 	 * getPrincipalsByPrefix.
 	 *
 	 * @param string $path
-	 * @return array
+	 * @return array|null
 	 */
 	public function getPrincipalByPath($path) {
 		if ($path === 'principals/system/system') {

core/Command/Config/ListConfigs.php

@@ -135,7 +135,7 @@ protected function getSystemConfigs($noSensitiveValues) {
 	 */
 	protected function getAppConfigs($app, $noSensitiveValues) {
 		if ($noSensitiveValues) {
-			return $this->appConfig->getFilteredValues($app, false);
+			return $this->appConfig->getFilteredValues($app);
 		} else {
 			return $this->appConfig->getValues($app, false);
 		}

lib/private/App/AppStore/Fetcher/Fetcher.php

@@ -187,7 +187,7 @@ public function get($allowUnstable = false) {
 
 		// Refresh the file content
 		try {
-			$responseJson = $this->fetch($ETag, $content, $allowUnstable);
+			$responseJson = $this->fetch($ETag, $content);
 
 			if (empty($responseJson)) {
 				return [];