Merge pull request #16638 from nextcloud/fix/noid/ldap-ext-storage-handler-loading-cli

delay sending event from app init to when they are needed

Author: rullzer

apps/files_external/lib/AppInfo/Application.php

@@ -93,12 +93,6 @@ public function __construct(array $urlParams = []) {
 		// force-load auth mechanisms since some will register hooks
 		// TODO: obsolete these and use the TokenProvider to get the user's password from the session
 		$this->getAuthMechanisms();
-
-		// don't remove this, as app loading order might be a side effect and
-		// querying the service from the server not reliable
-		\OC::$server->getEventDispatcher()->dispatch(
-			'OCA\\Files_External::loadAdditionalBackends'
-		);
 	}
 
 	/**

apps/files_external/lib/Service/BackendService.php

@@ -106,7 +106,18 @@ public function registerBackendProvider(IBackendProvider $provider) {
 		$this->backendProviders[] = $provider;
 	}
 
+	private function callForRegistrations() {
+		static $eventSent = false;
+		if(!$eventSent) {
+			\OC::$server->getEventDispatcher()->dispatch(
+				'OCA\\Files_External::loadAdditionalBackends'
+			);
+			$eventSent = true;
+		}
+	}
+
 	private function loadBackendProviders() {
+		$this->callForRegistrations();
 		foreach ($this->backendProviders as $provider) {
 			$this->registerBackends($provider->getBackends());
 		}
@@ -124,6 +135,7 @@ public function registerAuthMechanismProvider(IAuthMechanismProvider $provider)
 	}
 
 	private function loadAuthMechanismProviders() {
+		$this->callForRegistrations();
 		foreach ($this->authMechanismProviders as $provider) {
 			$this->registerAuthMechanisms($provider->getAuthMechanisms());
 		}
@@ -321,6 +333,7 @@ public function registerConfigHandler(string $placeholder, callable $configHandl
 	}
 
 	protected function loadConfigHandlers():void {
+		$this->callForRegistrations();
 		$newLoaded = false;
 		foreach ($this->configHandlerLoaders as $placeholder => $loader) {
 			$handler = $loader();