Preparing PyLint for subpackage breakup.

Author: dhermes

scripts/run_pylint.py

@@ -33,10 +33,13 @@
 IGNORED_DIRECTORIES = [
     os.path.join('google', 'cloud', 'bigtable', '_generated'),
     os.path.join('google', 'cloud', 'datastore', '_generated'),
-    'scripts/verify_included_modules.py',
 ]
 IGNORED_FILES = [
     os.path.join('docs', 'conf.py'),
+]
+IGNORED_POSTFIXES = [
+    os.path.join('google', '__init__.py'),
+    os.path.join('google', 'cloud', '__init__.py'),
     'setup.py',
 ]
 SCRIPTS_DIR = os.path.abspath(os.path.dirname(__file__))
@@ -113,6 +116,9 @@ def make_test_rc(base_rc_filename, additions_dict,
 
 def valid_filename(filename):
     """Checks if a file is a Python file and is not ignored."""
+    for postfix in IGNORED_POSTFIXES:
+        if filename.endswith(postfix):
+            return False
     for directory in IGNORED_DIRECTORIES:
         if filename.startswith(directory):
             return False

scripts/verify_included_modules.py

@@ -57,6 +57,9 @@
     'google.cloud.vision.__init__',
     'google.cloud.vision.fixtures',
 ])
+PACKAGES = (
+    '',
+)
 
 
 class SphinxApp(object):
@@ -127,17 +130,24 @@ def main(build_root='_build'):
     :param build_root: The root of the directory where docs are built into.
                        Defaults to ``_build``.
     """
+    if build_root is None:
+        parser = get_parser()
+        args = parser.parse_args()
+        build_root = args.build_root
+
     object_inventory_relpath = os.path.join(build_root, 'html', 'objects.inv')
 
     mock_uri = ''
     inventory = fetch_inventory(SphinxApp, mock_uri,
                                 object_inventory_relpath)
     sphinx_mods = set(inventory['py:module'].keys())
 
-    library_dir = os.path.join(BASE_DIR, 'google', 'cloud')
-    public_mods = get_public_modules(library_dir,
-                                     base_package='google.cloud')
-    public_mods = set(public_mods)
+    public_mods = set()
+    for package in PACKAGES:
+        library_dir = os.path.join(BASE_DIR, package, 'google', 'cloud')
+        package_mods = get_public_modules(library_dir,
+                                          base_package='google.cloud')
+        public_mods.update(package_mods)
 
     if not sphinx_mods <= public_mods:
         unexpected_mods = sphinx_mods - public_mods
@@ -173,6 +183,4 @@ def get_parser():
 
 
 if __name__ == '__main__':
-    parser = get_parser()
-    args = parser.parse_args()
-    main(build_root=args.build_root)
+    main(build_root=None)