Skip to content

Commit 8522653

Browse files
committed
Merge pull request #996 from dhermes/upgrade-pubsub-version
Upgrading pubsub to v1.
2 parents fcf5238 + e067635 commit 8522653

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

gcloud/pubsub/connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class Connection(base_connection.JSONConnection):
2828
API_BASE_URL = 'https://pubsub.googleapis.com'
2929
"""The base of the API call URL."""
3030

31-
API_VERSION = 'v1beta2'
31+
API_VERSION = 'v1'
3232
"""The version of the API, used in building the API call's URL."""
3333

3434
API_URL_TEMPLATE = '{api_base_url}/{api_version}{path}'

gcloud/pubsub/subscription.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def modify_ack_deadline(self, ack_id, ack_deadline, client=None):
246246
``client`` stored on the current subscription's topic.
247247
"""
248248
client = self._require_client(client)
249-
data = {'ackId': ack_id, 'ackDeadlineSeconds': ack_deadline}
249+
data = {'ackIds': [ack_id], 'ackDeadlineSeconds': ack_deadline}
250250
client.connection.api_request(
251251
method='POST', path='%s:modifyAckDeadline' % (self.path,),
252252
data=data)

gcloud/pubsub/test_subscription.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ def test_modify_ack_deadline_w_bound_client(self):
427427
self.assertEqual(req['method'], 'POST')
428428
self.assertEqual(req['path'], '/%s:modifyAckDeadline' % SUB_PATH)
429429
self.assertEqual(req['data'],
430-
{'ackId': ACK_ID, 'ackDeadlineSeconds': DEADLINE})
430+
{'ackIds': [ACK_ID], 'ackDeadlineSeconds': DEADLINE})
431431

432432
def test_modify_ack_deadline_w_alternate_client(self):
433433
PROJECT = 'PROJECT'
@@ -449,7 +449,7 @@ def test_modify_ack_deadline_w_alternate_client(self):
449449
self.assertEqual(req['method'], 'POST')
450450
self.assertEqual(req['path'], '/%s:modifyAckDeadline' % SUB_PATH)
451451
self.assertEqual(req['data'],
452-
{'ackId': ACK_ID, 'ackDeadlineSeconds': DEADLINE})
452+
{'ackIds': [ACK_ID], 'ackDeadlineSeconds': DEADLINE})
453453

454454
def test_delete_w_bound_client(self):
455455
PROJECT = 'PROJECT'

0 commit comments

Comments
 (0)