Skip to content

Commit 5b6631a

Browse files
authored
Merge pull request #2378 from tseaver/2368-bigquery-async_query_job-results
Ensure that 'QueryResults.from_query_job' copies 'job.name'.
2 parents c8a2517 + c2f84ab commit 5b6631a

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

google/cloud/bigquery/query.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ def from_query_job(cls, job):
7777
"""
7878
instance = cls(job.query, job._client, job.udf_resources)
7979
instance._job = job
80+
job_ref = instance._properties.setdefault('jobReference', {})
81+
job_ref['jobId'] = job.name
8082
if job.default_dataset is not None:
8183
instance.default_dataset = job.default_dataset
8284
if job.use_query_cache is not None:

unit_tests/bigquery/test_query.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ def test_from_query_job(self):
155155

156156
query = klass.from_query_job(job)
157157

158+
self.assertEqual(query.name, self.JOB_NAME)
158159
self.assertEqual(query.query, self.QUERY)
159160
self.assertIs(query._client, client)
160161
self.assertIs(query._job, job)

0 commit comments

Comments
 (0)