Skip to content

Commit 4c86521

Browse files
committed
Move debug logging call in Future.add_done_callback (#4167)
1 parent e1a2483 commit 4c86521

File tree

1 file changed

+6
-1
lines changed
  • pubsub/google/cloud/pubsub_v1/subscriber/policy

1 file changed

+6
-1
lines changed

pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@
3030
logger = logging.getLogger(__name__)
3131

3232

33+
def _callback_completed(future):
34+
"""Simple callback that just logs a `Future`'s result."""
35+
logger.debug('Result: %s', future.result())
36+
37+
3338
class Policy(base.BasePolicy):
3439
"""A consumer class based on :class:`threading.Thread`.
3540
@@ -144,4 +149,4 @@ def on_response(self, response):
144149
logger.debug(self._callback)
145150
message = Message(msg.message, msg.ack_id, self._request_queue)
146151
future = self._executor.submit(self._callback, message)
147-
logger.debug('Result: %s' % future.result())
152+
future.add_done_callback(_callback_completed)

0 commit comments

Comments
 (0)