Skip to content

Commit d4b4e81

Browse files
authored
fix(docs): place doc comment above the last overload (#544)
* fix(docs): place doc comment above the last overload * fix lint
1 parent 531b0d0 commit d4b4e81

File tree

7 files changed

+278
-283
lines changed

7 files changed

+278
-283
lines changed

handwritten/storage/src/acl.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,8 @@ class Acl extends AclRoleAccessorMethods {
381381
this.request_ = options.request;
382382
}
383383

384+
add(options: AddAclOptions): Promise<AddAclResponse>;
385+
add(options: AddAclOptions, callback: AddAclCallback): void;
384386
/**
385387
* @typedef {array} AddAclResponse
386388
* @property {object} 0 The Acl Objects.
@@ -454,8 +456,6 @@ class Acl extends AclRoleAccessorMethods {
454456
* region_tag:storage_add_bucket_default_owner
455457
* Example of adding a default owner to a bucket:
456458
*/
457-
add(options: AddAclOptions): Promise<AddAclResponse>;
458-
add(options: AddAclOptions, callback: AddAclCallback): void;
459459
add(options: AddAclOptions,
460460
callback?: AddAclCallback): void|Promise<AddAclResponse> {
461461
const query = {} as AclQuery;
@@ -488,6 +488,8 @@ class Acl extends AclRoleAccessorMethods {
488488
});
489489
}
490490

491+
delete(options: RemoveAclOptions): Promise<RemoveAclResponse>;
492+
delete(options: RemoveAclOptions, callback: RemoveAclCallback): void;
491493
/**
492494
* @typedef {array} RemoveAclResponse
493495
* @property {object} 0 The full API response.
@@ -548,8 +550,6 @@ class Acl extends AclRoleAccessorMethods {
548550
* region_tag:storage_remove_file_owner
549551
* Example of removing an owner from a bucket:
550552
*/
551-
delete(options: RemoveAclOptions): Promise<RemoveAclResponse>;
552-
delete(options: RemoveAclOptions, callback: RemoveAclCallback): void;
553553
delete(options: RemoveAclOptions, callback?: RemoveAclCallback):
554554
void|Promise<RemoveAclResponse> {
555555
const query = {} as AclQuery;
@@ -573,6 +573,9 @@ class Acl extends AclRoleAccessorMethods {
573573
});
574574
}
575575

576+
get(options?: GetAclOptions): Promise<GetAclResponse>;
577+
get(options: GetAclOptions, callback: GetAclCallback): void;
578+
get(callback: GetAclCallback): void;
576579
/**
577580
* @typedef {array} GetAclResponse
578581
* @property {object|object[]} 0 Single or array of Acl Objects.
@@ -656,9 +659,6 @@ class Acl extends AclRoleAccessorMethods {
656659
* region_tag:storage_print_bucket_acl_for_user
657660
* Example of printing a bucket's ACL for a specific user:
658661
*/
659-
get(options?: GetAclOptions): Promise<GetAclResponse>;
660-
get(options: GetAclOptions, callback: GetAclCallback): void;
661-
get(callback: GetAclCallback): void;
662662
get(optionsOrCallback?: GetAclOptions|GetAclCallback,
663663
cb?: GetAclCallback): void|Promise<GetAclResponse> {
664664
const options =
@@ -703,6 +703,8 @@ class Acl extends AclRoleAccessorMethods {
703703
});
704704
}
705705

706+
update(options: UpdateAclOptions): Promise<UpdateAclResponse>;
707+
update(options: UpdateAclOptions, callback: UpdateAclCallback): void;
706708
/**
707709
* @typedef {array} UpdateAclResponse
708710
* @property {object} 0 The updated Acl Objects.
@@ -760,8 +762,6 @@ class Acl extends AclRoleAccessorMethods {
760762
* const apiResponse = data[1];
761763
* });
762764
*/
763-
update(options: UpdateAclOptions): Promise<UpdateAclResponse>;
764-
update(options: UpdateAclOptions, callback: UpdateAclCallback): void;
765765
update(options: UpdateAclOptions, callback?: UpdateAclCallback):
766766
void|Promise<UpdateAclResponse> {
767767
const query = {} as AclQuery;

0 commit comments

Comments
 (0)