Skip to content

Commit a2dae25

Browse files
krzkgregkh
authored andcommitted
extcon: adc-jack: Cleanup wakeup source only if it was enabled
commit 92bac7d upstream. Driver in the probe enables wakeup source conditionally, so the cleanup path should do the same - do not release the wakeup source memory if it was not allocated. Link: https://lore.kernel.org/lkml/20250509071703.39442-2-krzysztof.kozlowski@linaro.org/ Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Closes: https://lore.kernel.org/r/22aaebb7-553b-4571-8a43-58a523241082@wanadoo.fr/ Fixes: 78b6a99 ("extcon: adc-jack: Fix wakeup source leaks on device unbind") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 86e7baf commit a2dae25

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/extcon/extcon-adc-jack.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ static void adc_jack_remove(struct platform_device *pdev)
164164
{
165165
struct adc_jack_data *data = platform_get_drvdata(pdev);
166166

167-
device_init_wakeup(&pdev->dev, false);
167+
if (data->wakeup_source)
168+
device_init_wakeup(&pdev->dev, false);
168169
free_irq(data->irq, data);
169170
cancel_work_sync(&data->handler.work);
170171
}

0 commit comments

Comments
 (0)