Add new logs to debug guilds-bar-view component#114
Merged
SzymczakJ merged 3 commits into0.78.0-discordfrom Nov 4, 2025
Merged
Add new logs to debug guilds-bar-view component#114SzymczakJ merged 3 commits into0.78.0-discordfrom
SzymczakJ merged 3 commits into0.78.0-discordfrom
Conversation
bdafe7a to
02dfe0b
Compare
Author
|
Tested and builds/runs well, I'm merging as this is only a small logging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Thanks to these(eg.: 1, 2, 3) new logs we know that the only place that dispatchDraw NPE error throws is this GuildsBar NativeView. With that information we know that we can put Sentry logs in
onViewRemovedonly for that component, as it will not spam to Sentry too much. With logs in onViewRemoved we will hopefully get more info on what changes the view hierarchy in drawing phase.Changelog:
Test Plan: