CLOUDSTACK-9630: Cannot use listNics API as advertised

added "type" details for listNics API response.

Author: Sudhansu

server/src/com/cloud/api/ApiResponseHelper.java

@@ -3433,6 +3433,7 @@ public NicResponse createNicResponse(Nic result) {
         NicResponse response = new NicResponse();
         NetworkVO network = _entityMgr.findById(NetworkVO.class, result.getNetworkId());
         VMInstanceVO vm = _entityMgr.findById(VMInstanceVO.class, result.getInstanceId());
+        UserVmJoinVO userVm = _entityMgr.findById(UserVmJoinVO.class, result.getInstanceId());
 
         response.setId(result.getUuid());
         response.setNetworkid(network.getUuid());
@@ -3441,6 +3442,14 @@ public NicResponse createNicResponse(Nic result) {
             response.setVmId(vm.getUuid());
         }
 
+        if (userVm != null){
+            if (userVm.getTrafficType() != null) {
+                response.setTrafficType(userVm.getTrafficType().toString());
+            }
+            if (userVm.getGuestType() != null) {
+                response.setType(userVm.getGuestType().toString());
+            }
+        }
         response.setIpaddress(result.getIPv4Address());
 
         if (result.getSecondaryIp()) {
@@ -3461,10 +3470,21 @@ public NicResponse createNicResponse(Nic result) {
         response.setNetmask(result.getIPv4Netmask());
         response.setMacAddress(result.getMacAddress());
 
+        if (result.getBroadcastUri() != null) {
+            response.setBroadcastUri(result.getBroadcastUri().toString());
+        }
+        if (result.getIsolationUri() != null) {
+            response.setIsolationUri(result.getIsolationUri().toString());
+        }
+
         if (result.getIPv6Address() != null) {
             response.setIp6Address(result.getIPv6Address());
         }
 
+        if (result.getIPv6Cidr() != null) {
+            response.setIp6Cidr(result.getIPv6Cidr());
+        }
+
         response.setDeviceId(String.valueOf(result.getDeviceId()));
 
         response.setIsDefault(result.isDefaultNic());