fix(runtime): Unload framework bundles in SymbolLoader::load#1257
Merged
mbektchiev merged 2 commits intomasterfrom Feb 19, 2020
Merged
fix(runtime): Unload framework bundles in SymbolLoader::load#1257mbektchiev merged 2 commits intomasterfrom
mbektchiev merged 2 commits intomasterfrom
Conversation
`getBlacklistedRusage_info_v0` shouldn't be called as its return type is excluded from metadata.
* Use NSBundle to load bundles instead of `CFBundleLoadExecutable` * Do not attempt load a bundle more times than it is needed * Unload the bundle if it's state was previously unloaded. Sometimes framework bundles use resource bundles of the same name and keeping the framework loaded breaks them. OTH, loading and unloading a framework bundle is sufficient for its. executable code to be registered with the Objective-C runtime.
44abb25 to
9796e38
Compare
vmutafov
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFBundleLoadExecutableframework bundles use resource bundles of the same name and keeping
the framework loaded breaks them. OTH, loading and unloading a framework
bundle is sufficient for its executable code to be registered with the
Objective-C runtime.
PR Checklist
refs #1252