fix: don't crash app if flag is present#1230
Merged
mbektchiev merged 3 commits intoNativeScript:masterfrom Nov 28, 2019
Merged
Conversation
mbektchiev
suggested changes
Nov 26, 2019
Contributor
mbektchiev
left a comment
There was a problem hiding this comment.
Hi @DickSmith, thank you for the PR! It generally looks good, I'd like you to address the comment and warn you that exiting instead of throwing an exception could mean that automatic exception reporting by Crashlitics could be hindered. The uncaught JS error handler, however, will get called. So if an app has logic for reporting errors there (which is always a good idea), this shouldn't be an issue.
mbektchiev
approved these changes
Nov 28, 2019
Contributor
|
run ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behaviour?
App will crash.
What is the new behaviour?
App will shutdown.