fix: Remove 60 MB (28%) of dev dependencies from final docker images#28160
Merged
Koenkk merged 1 commit intoKoenkk:devfrom Aug 4, 2025
krkk:docker-no-devdeps
Merged
fix: Remove 60 MB (28%) of dev dependencies from final docker images#28160Koenkk merged 1 commit intoKoenkk:devfrom krkk:docker-no-devdeps
Koenkk merged 1 commit intoKoenkk:devfrom
krkk:docker-no-devdeps
Conversation
All development dependencies were previously bundled in the final image. Most notably, this included typescript compiler (22 MiB), esbuild (12.7 MiB), and some type declaration packages. Not copying development dependencies saves about 60 MB of storage space. For x86_64 this makes the image size go down from 217 MiB to 156 MiB, and similarly for arm64 -- from 213 MiB to 153 MiB.
CodSpeed Performance ReportMerging #28160 will not alter performanceComparing Summary
|
Collaborator
|
pnpm is ignoring this? Line 5 in 0bdc3fd |
Contributor
Author
|
seems like it started ignoring that in v10.x, yeah. huh compare https://pnpm.io/9.x/cli/install#--prod--p and https://pnpm.io/10.x/cli/install#--prod--p there's also a linked issue in the v10.0.0 changelog: pnpm/pnpm#8827 |
Owner
|
Thanks! I checked the HA addon and there it was already applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All development dependencies were previously bundled in the final image.
Most notably, this included typescript compiler (22 MiB), esbuild (12.7 MiB), and some type declaration packages.
Not copying development dependencies saves about 60 MB of storage space.
For x86_64 this makes the image size go down from 217 MiB to 156 MiB, and similarly for arm64 – from 213 MiB to 153 MiB.
Honestly, I'm not familiar with docker and nodejs ecosystem much and I only started using z2m just this week.
Buuuut it seems working 😅, though idk if some package like typescript was also used for extensions..