Skip to content

Commit 5317112

Browse files
cojencoandrewsg
andauthored
chore: update samples testing and readme (#1022)
* chore: update samples testing and readme * update version --------- Co-authored-by: Andrew Gorcester <gorcester@google.com>
1 parent a50d6cb commit 5317112

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

storage/samples/snippets/requester_pays_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
import backoff
1516
import os
1617
import tempfile
1718

19+
from google.api_core.exceptions import GoogleAPIError
1820
from google.cloud import storage
1921
import pytest
2022

@@ -31,18 +33,21 @@
3133
PROJECT = os.environ["GOOGLE_CLOUD_PROJECT"]
3234

3335

36+
@backoff.on_exception(backoff.expo, GoogleAPIError, max_time=60)
3437
def test_enable_requester_pays(capsys):
3538
storage_enable_requester_pays.enable_requester_pays(BUCKET)
3639
out, _ = capsys.readouterr()
3740
assert f"Requester Pays has been enabled for {BUCKET}" in out
3841

3942

43+
@backoff.on_exception(backoff.expo, GoogleAPIError, max_time=60)
4044
def test_disable_requester_pays(capsys):
4145
storage_disable_requester_pays.disable_requester_pays(BUCKET)
4246
out, _ = capsys.readouterr()
4347
assert f"Requester Pays has been disabled for {BUCKET}" in out
4448

4549

50+
@backoff.on_exception(backoff.expo, GoogleAPIError, max_time=60)
4651
def test_get_requester_pays_status(capsys):
4752
storage_get_requester_pays_status.get_requester_pays_status(BUCKET)
4853
out, _ = capsys.readouterr()
@@ -58,6 +63,7 @@ def test_blob():
5863
return blob
5964

6065

66+
@backoff.on_exception(backoff.expo, GoogleAPIError, max_time=60)
6167
def test_download_file_requester_pays(test_blob, capsys):
6268
with tempfile.NamedTemporaryFile() as dest_file:
6369
storage_download_file_requester_pays.download_file_requester_pays(

storage/samples/snippets/snippets_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
import storage_upload_from_stream
7979
import storage_upload_with_kms_key
8080

81-
KMS_KEY = os.environ["CLOUD_KMS_KEY"]
81+
KMS_KEY = os.environ.get("CLOUD_KMS_KEY")
8282

8383

8484
def test_enable_default_kms_key(test_bucket):

0 commit comments

Comments
 (0)