fix: address PR review comments

- Keep `traceViewerTracesDir` in sync on every URL request, not just
  on first server creation (app.tsx)
- Reset per-session trace state (`sessionTraces`, `sessionUserMsgIds`)
  when restarting the event stream in worker.ts
- Fix "traceFile" variable-style wording in test file comments to use
  natural language ("trace file", "trace viewer", "trace list")

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

packages/opencode/src/cli/cmd/tui/app.tsx

@@ -40,8 +40,11 @@ import fsAsync from "fs/promises"
 let traceViewerServer: ReturnType<typeof Bun.serve> | undefined
 let traceViewerTracesDir: string | undefined
 function getTraceViewerUrl(sessionID: string, tracesDir?: string): string {
+  // Always update the traces dir so subsequent calls with a new tracesDir
+  // don't serve stale paths from the initial server creation.
+  traceViewerTracesDir = Trace.getTracesDir(tracesDir)
+
   if (!traceViewerServer) {
-    traceViewerTracesDir = Trace.getTracesDir(tracesDir)
     traceViewerServer = Bun.serve({
       port: 0, // random available port
       hostname: "127.0.0.1",

packages/opencode/src/cli/cmd/tui/worker.ts

@@ -108,6 +108,13 @@ function getOrCreateTrace(sessionID: string): Trace | null {
 
 const startEventStream = (input: { directory: string; workspaceID?: string }) => {
   if (eventStream.abort) eventStream.abort.abort()
+  // Clear stale per-stream trace state before starting a new stream instance
+  for (const [, trace] of sessionTraces) {
+    void trace.endTrace().catch(() => {})
+  }
+  sessionTraces.clear()
+  sessionUserMsgIds.clear()
+
   const abort = new AbortController()
   eventStream.abort = abort
   const signal = abort.signal

packages/opencode/test/altimate/tracing-adversarial-snapshot.test.ts

@@ -4,7 +4,7 @@
  *
  * Each test targets a specific code path or race condition found during
  * line-by-line audit of snapshot(), buildTraceFile(), worker.ts tracing,
- * and the live traceFile viewer.
+ * and the live trace viewer.
  */
 
 import { describe, expect, test, beforeEach, afterEach } from "bun:test"

packages/opencode/test/altimate/tracing-de-attributes.test.ts

@@ -1,5 +1,5 @@
 /**
- * Tests for data engineering domain-specific traceFile attributes.
+ * Tests for data engineering domain-specific trace file attributes.
  *
  * Verifies that:
  *   1. Domain attributes are purely optional — traces work without them

packages/opencode/test/altimate/tracing-display-crash.test.ts

@@ -1,5 +1,5 @@
 /**
- * Tests for traceFile list display, title handling, formatting utilities,
+ * Tests for trace list display, title handling, formatting utilities,
  * flushSync crash recovery, initial snapshot, and sorting.
  *
  * These test the latest additions that were previously uncovered.

packages/opencode/test/altimate/tracing-e2e.test.ts

@@ -3,11 +3,11 @@
  *
  * These tests simulate real agent sessions — not mocked — to verify:
  *   1. Incremental snapshots are written during a session (partial traces)
- *   2. The traceFile file is valid and complete at every point
+ *   2. The trace file is valid and complete at every point
  *   3. Concurrent sessions don't interfere with each other
  *   4. Performance: tracing adds negligible overhead (<5ms per operation)
  *   5. The TUI worker's tracing code doesn't crash on malformed events
- *   6. The traceFile viewer server works correctly
+ *   6. The trace viewer server works correctly
  *   7. The full write→snapshot→read→render pipeline works end-to-end
  */